Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker labels, production docker-compose and simple fixes. #824

Merged
merged 4 commits into from
Aug 16, 2019

Conversation

kmehant
Copy link
Collaborator

@kmehant kmehant commented Aug 14, 2019

Description

  1. Add docker-compose configuration for the production use case
  2. Fix web Dockerfile build failure due to alpine images and lack of build dependencies.
  3. Update Dockefile labels.
  4. Update documentation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmehant
Copy link
Collaborator Author

kmehant commented Aug 14, 2019

@JaDogg @vivonk @agentmilindu Please review and we shall merge this to have a full-fledged docker-compose setup :)

@kmehant
Copy link
Collaborator Author

kmehant commented Aug 14, 2019

@JaDogg @vivonk I have tested this setup thoroughly.

@vivonk vivonk merged commit 4ca33fd into scorelab:develop Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants