Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/aws #542

Merged
merged 9 commits into from
Oct 28, 2018
Merged

Feature/aws #542

merged 9 commits into from
Oct 28, 2018

Conversation

dulajra
Copy link

@dulajra dulajra commented Oct 25, 2018 •
edited
Loading

  • Added CFT and required scripts to create an ECS with a sample application.
  • This pull request contains work related only for cluster creation. I am using a test service with a busybox container just for testing here. Real Bassa service deployment is done in a future pull request.

swatisingh45
swatisingh45 reviewed Oct 25, 2018
View reviewed changes
Copy link

@swatisingh45 swatisingh45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, @vivonk should take a look into this.

@agentmilindu
Copy link
Collaborator

@dulajra Nice work! I'll give a try to deploy Bassa with this on AWS and merge this. Thanks a lot for the good work.

@dulajra dulajra mentioned this pull request Oct 26, 2018
Merged
@agentmilindu
Copy link
Collaborator

@malithsen @rehrumesh @vivonk Please review

@agentmilindu agentmilindu merged commit bdf1a54 into scorelab:develop Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisingh45 swatisingh45 swatisingh45 left review comments

@malithsen malithsen malithsen approved these changes

@agentmilindu agentmilindu agentmilindu approved these changes

@charithccmc charithccmc Awaiting requested review from charithccmc

@rehrumesh rehrumesh Awaiting requested review from rehrumesh

@tharindupr tharindupr Awaiting requested review from tharindupr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dulajra @agentmilindu @malithsen @swatisingh45 @data1435