Replace manual types with generated types and cut a new tag for v1 #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes moving from the manual types to types generated from the json schema itself.
The schema is imported by a
git subtree pull
and converted into types bygithub.com/atombender/go-jsonschema
To avoid breaking compatibility with existing code, we cut a /v1 suffix (and assume the existing branch is v0).
This allows existing code to continue importing the "bare" type as
github.com/score-spec/score-go
while new code, or code upgraded to use this tag can usegithub.com/score-spec/score-go/v1
.Types of changes