Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual types with generated types and cut a new tag for v1 #23

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

astromechza
Copy link
Member

@astromechza astromechza commented Jan 25, 2024

This PR proposes moving from the manual types to types generated from the json schema itself.

The schema is imported by a git subtree pull and converted into types by github.com/atombender/go-jsonschema

To avoid breaking compatibility with existing code, we cut a /v1 suffix (and assume the existing branch is v0).

This allows existing code to continue importing the "bare" type as github.com/score-spec/score-go while new code, or code upgraded to use this tag can use github.com/score-spec/score-go/v1.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Copy link
Contributor

@delca85 delca85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astromechza astromechza merged commit d718ed8 into score-spec:main Jan 26, 2024
2 checks passed
@astromechza astromechza deleted the v2-generated-types branch January 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants