Support inclusive/exclusive ranges for sorted sets #35 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72squared
force-pushed
the
jl-zrange-inclusive
branch
from
a19096e
to
9c33327
Compare
scoquelin
reviewed
Sep 4, 2024
| * @param inclusive Whether the boundary is inclusive. default is false. | ||
| * @tparam T The value type | ||
| */ | ||
| case class Boundary[T](value: Option[T] = None, inclusive: Boolean = false) |
There was a problem hiding this comment.
After making Boundary type argument covariant [+T], this basically allows Boundary(Option[Nothing]) (which is basically the unbounded case) to be used together with other Boundary(Option[T]) and you can get rid of all the new Boundary(...) and new ZRange(...) in the code below
| * @tparam T The value type | ||
| * @return The boundary | ||
| */ | ||
| def unbounded[T]: Boundary[T] = new Boundary[T](None) |
There was a problem hiding this comment.
Suggested change
| def unbounded[T]: Boundary[T] = new Boundary[T](None) | |
| def unbounded[T]: Boundary[T] = Boundary(None) |
72squared
force-pushed
the
jl-zrange-inclusive
branch
from
9c33327
to
1933243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.