Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for remaining sorted-set commands #31 #34

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

72squared
Copy link
Collaborator

Quite a few commands in there. took me a while.

Discovered that we may need to come back and refactor the ZRange class to support inclusive or exclusive ranges.

@72squared 72squared self-assigned this Aug 22, 2024
@72squared
Copy link
Collaborator Author

Closes Issue #31

Copy link
Owner

@scoquelin scoquelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the remaining functions! 🙏

We might want to create an issue for the inclusive/exclusive ranges to keep track of it!

@72squared 72squared merged commit a56aee1 into main Aug 22, 2024
3 checks passed
@72squared
Copy link
Collaborator Author

Here is the issue: #35

@72squared 72squared deleted the jl-zset-remaining branch September 4, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants