Support for zmpop and bzmpop commands #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially addresses issue #31 |
72squared
commented
Aug 14, 2024
| */ | ||
| def bzPopMax(timeout: Long, keys: K*): Future[Option[ScoreWithKeyValue[K,V]]] | ||
| def bzPopMin(timeout: FiniteDuration, keys: K*): Future[Option[ScoreWithKeyValue[K,V]]] |
There was a problem hiding this comment.
I switched all the sorted set commands from specifying timeouts for blocking operations from longs and doubles to FiniteDuration. much clearer about intent and more consistent with how other Arugula commands are implemented.
72squared
commented
Aug 14, 2024
| @@ -401,4 +423,11 @@ object RedisSortedSetAsyncCommands { | |||
| final case class ScoreWithKeyValue[K, V](score: Double, key: K, value: V) | |||
| final case class ZRange[T](start: T, end: T) | |||
| final case class RangeLimit(offset: Long, count: Long) | |||
|
|
|||
| sealed trait SortOrder | |||
There was a problem hiding this comment.
I didn't know what to call this enum. Direction didn't seem quite right to me.
There was a problem hiding this comment.
SortPriority maybe ? Anyway, SortOrder works fine too!
scoquelin
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.