implement a bunch of sorted set commands, first pass. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72squared
force-pushed
the
jl-sorted-set-pt1
branch
from
81bebb0
to
70fe6ec
Compare
|
This addresses about half of the work mentioned in #31 |
scoquelin
approved these changes
Aug 13, 2024
| def zRankWithScore(key: K, value: V): Future[Option[ScoreWithValue[Long]]] | ||
|
|
||
| /** | ||
| * Determine the index of a member in a sorted set, with the score |
There was a problem hiding this comment.
minor : I think this method would only return the index
72squared
force-pushed
the
jl-sorted-set-pt1
branch
from
70fe6ec
to
cd7416f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still quite a few commands left to be implemented but they are less commonly used. I will take them on in a subsequent MR. This one is already getting pretty big.