Check that ruptime is present before calling #390
Conversation
Avoids calling command_not_found_handle which might take considerable time.
|
We do this a lot, and I'd rather not start changing all of them or bits here and there. I wonder if there's a clean and robust way we could disable command_not_found_handle for the duration of running completions instead, for example in _init_completion. Actually this might be something to suggest upstream bash do by default. |
|
When I was preparing change I noticed 10 lines above It might be possible to save command_not_found_handle state in the beginning, unset this function and restore after completion just like described here: https://mharrison.org/post/bashfunctionoverride/ Don't sure how safe and robust it is. |
|
Ok, fair enough re avahi-browse. A centralized approach would still be preferred, as just calling stuff is what we do pretty much everywhere else in the codebase, and FWIW I'd rather keep it that way. The linked solution irks me though, and I'm not sure if we have a place to cleanly restore the original function. |
When either one of the commands "cc", "c++", "f77", and "f95" is not found in the system, on the first load of "gcc" completions, "command_not_found_handle" hook (typically set by distributions) is invoked in the middle of completion, breaks the terminal layout by outputting messages, and eats user inputs. This commit fixes the issue by checking the existence of commands before running these commands. Refs. akinomyoga/ble.sh#203 akinomyoga/ble.sh#192 scop#390
When at least one of the commands "cc", "c++", "f77", and "f95" is not found in the system, on the first load of "gcc" completions, "command_not_found_handle" hook (typically set by distributions) is invoked in the middle of completion, breaks the terminal layout by outputting messages, and eats user inputs. This commit fixes the issue by checking the existence of commands before running these commands. Refs. scop#390 akinomyoga/ble.sh#192 akinomyoga/ble.sh#203
When at least one of the commands "cc", "c++", "f77", and "f95" is not found in the system, on the first load of "gcc" completions, "command_not_found_handle" hook (typically set by distributions) is invoked in the middle of completion, breaks the terminal layout by outputting messages, and eats user inputs. This commit fixes the issue by checking the existence of commands before running these commands. Refs. scop#390 akinomyoga/ble.sh#192 akinomyoga/ble.sh#203
Avoids calling command_not_found_handle which might take considerable
time.
For instance on my system command_not_found_handle takes more than 200ms. I don't want this delay every time I complete hostname!