fix(_known_hosts_real): fix nounset/failglob with _comp_split, etc #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
approved these changes
Aug 6, 2023
Co-authored-by: Ville Skyttä <[email protected]>
The previous implementation would cause the `nounset` error by an access to non-existent $1 when a line with only a marker is contained in known_hosts. This patch fixes it and also rewrite the code not to use the positional parameters.
Co-authored-by: Ville Skyttä <[email protected]>
akinomyoga
force-pushed
the
_known_hosts_real
branch
from
6d7c025
to
470a644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.