-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adjust API/naming of generators #1029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
fixup-api-renaming
branch
from
August 13, 2023 00:58
a5180a7
to
ed0c995
Compare
akinomyoga
changed the title
[WIP] small fixes
[Waiting for #1028] refactor: adjust API/naming of generators
Aug 13, 2023
scop
reviewed
Aug 20, 2023
akinomyoga
force-pushed
the
fixup-api-renaming
branch
from
August 20, 2023 21:14
ed0c995
to
af52533
Compare
Rebased. |
akinomyoga
force-pushed
the
fixup-api-renaming
branch
2 times, most recently
from
August 26, 2023 11:55
68323e4
to
31e0295
Compare
akinomyoga
changed the title
[Waiting for #1028] refactor: adjust API/naming of generators
refactor: adjust API/naming of generators
Aug 26, 2023
akinomyoga
force-pushed
the
fixup-api-renaming
branch
from
September 1, 2023 14:27
31e0295
to
1168f24
Compare
scop
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes on top of #1028 / Should be considered after merging #1028