Added initialLeft / Top to set initial crop region #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angekouf
suggested changes
May 30, 2017
There was a problem hiding this comment.
#Pretty good suggestion and I already downloaded for myself but you removed the crop button...
Also it would be better if the user could also set a precropped image to load at init.
@DangerD256 I made a pull request with my changes at your fork.
Fixing the removed crop button in your versiin... Also allowing the user to set a precropped image to load at init
angekouf
reviewed
May 30, 2017
croppic.js
Outdated
| @@ -401,7 +408,7 @@ | |||
| var cropControlZoomMuchOut = ''; | |||
| var cropControlRotateLeft = ''; | |||
| var cropControlRotateRight = ''; | |||
| var cropControlCrop = '<i class="cropControlCrop"></i>'; | |||
There was a problem hiding this comment.
By emptying the string the crop button is no longer initialized...
Fixing missing crop button and allow the user to set a precropped image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for recropping image is user wants to redo crop.