This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
Signed-off-by: steve lasker <[email protected]>
SteveLasker
requested review from
OR13,
letmaik,
JAG-UK,
henkbirkholz and
yogeshbdeshpande
September 29, 2023 23:18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits but otherwise looks good. (I am new to the community and cannot contribute or would otherwise approve with minor typo feedback and be more clear about my support despite the nits.)
Co-authored-by: A.J. Stein <[email protected]> Signed-off-by: Steve Lasker <[email protected]>
Co-authored-by: A.J. Stein <[email protected]> Signed-off-by: Steve Lasker <[email protected]>
Co-authored-by: A.J. Stein <[email protected]> Signed-off-by: Steve Lasker <[email protected]>
@aj-stein-nist, thanks for the reviews and feedback. All were merged. |
BTW, a non-member/non-binding LGTM is still appreciated and considered. Especially, this early in the process. |
OR13
approved these changes
Oct 9, 2023
johnandersen777
pushed a commit
to johnandersen777/scitt-api-emulator
that referenced
this pull request
Nov 23, 2023
* Markdown Linting, spelling and title case formatting * Readme cleanup * Formatted the output to make entry_id easier to read * Update docs/registration_policies.md Signed-off-by: steve lasker <[email protected]> Co-authored-by: A.J. Stein <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several updates to: