Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades Jedis library #656

Merged
merged 1 commit into from
May 28, 2024
Merged

Upgrades Jedis library #656

merged 1 commit into from
May 28, 2024

Conversation

mkeckmkeck
Copy link
Contributor

@mkeckmkeck mkeckmkeck commented May 27, 2024 •
edited
Loading

Description

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-921
  • This PR is related to PR:

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@mkeckmkeck
Upgrades Jedis library
ed02ae6 
- fixes library usage for jupiter by applying an disabled ClientSetInfoConfig
- see https://redis.io/docs/latest/commands/client-setinfo/ and
  redis/jedis#3356 (has follow-ups)

Fixes: SIRI-921
@mkeckmkeck mkeckmkeck added the ⬆️ Dependencies Pull requests that update a dependency file label May 27, 2024
idlira
idlira approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@idlira idlira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: what about upgrading the containers as well? Current version in docker is 7.2.5, we are using 7.0.12, at least in OXOMI systems.

@ymo-sci ymo-sci merged commit 9823a30 into develop May 28, 2024
3 of 4 checks passed
@ymo-sci ymo-sci deleted the feature/SIRI-921_upgrade_jedis branch May 28, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scireum-mbo scireum-mbo scireum-mbo approved these changes

@ymo-sci ymo-sci ymo-sci approved these changes

@idlira idlira idlira approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@sabieber sabieber sabieber approved these changes

Assignees
No one assigned
Labels
⬆️ Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkeckmkeck @sabieber @jakobvogel @idlira @ymo-sci @scireum-mbo