Optimize spectra merge and normalization #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the following optimizations: - Bypass some multi-threading shortcomings of DataArray.bin - Avoid bins.concat where possible - Use in-place normalization I have tried this on a 10 GByte file and it shaves off several seconds of runtime when returning event data.
nvaytet
reviewed
Feb 12, 2024
src/esssans/loki/io.py
Outdated
| @@ -38,6 +38,8 @@ def _patch_data( | |||
| ) -> sc.DataArray: | |||
| out = da.copy(deep=False) | |||
| if out.bins is not None: | |||
| # Currently ScippNexus adds 32 bit event weights, this may cause trouble. | |||
| out.bins.data = out.bins.data.to(dtype='float64', copy=False) | |||
There was a problem hiding this comment.
Does this also happen with the ISIS files?
There was a problem hiding this comment.
I think so actually. We should probably have a chat about this. It would be nice if we could keep 32 bit until needed, so I was not happy about changing this here.
Fixes #84. For 1e9 events this reduces the time for the call to this function from 10 seconds to 1 second.
Simpler and faster event-mode upper-bound broadcast
nvaytet
reviewed
Feb 15, 2024
| atol=sc.scalar(1e-11), | ||
| # Could be 1e-11, but currently the workflow defaults to float32 data, as | ||
| # returned by ScippNexus. | ||
| rtol=sc.scalar(1e-7), |
There was a problem hiding this comment.
Not sure I follow anymore. So the changes you made here have degraded the accuracy of the results?
There was a problem hiding this comment.
Yes, because I change numerator / denominator to numerator /= denominator. So previously we ended up converting to float64 in that step.
nvaytet
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following optimizations:
I have tried this on a 10 GByte file and it shaves off several seconds of runtime when returning event data.