Support event-mode I(Q) #65
Conversation
| @@ -21,6 +21,7 @@ | |||
| ) | |||
| from .common import transmission_from_background_run, transmission_from_sample_run | |||
| from .direct_beam import direct_beam | |||
| from .types import BackgroundSubtractedIofQ, IofQ, ReturnEvents, SampleRun | |||
There was a problem hiding this comment.
Not sure why we are now importing those on the top level? Was it to get away from the from types import *?
If so, should this be reflected in the notebooks?
There was a problem hiding this comment.
Yes. types is meaningless for the user. We should name (and categorize things) in a meaningful way. Yes, there are a lot of things that need updating, I wanted to do that separately, in particular given that there is also other ongoing work that may conflict.
There was a problem hiding this comment.
Should we sit down and discuss what would be the best way to do this, so we're all on the same page?
| @@ -41,6 +42,7 @@ | |||
| del importlib | |||
|
|
|||
| __all__ = [ | |||
| 'ReturnEvents', | |||
There was a problem hiding this comment.
Above, you import BackgroundSubtractedIofQ, IofQ, ReturnEvents, SampleRun
Should all of them be listed here?
| variances by the number of events in each bin. An explicit broadcast is performed | ||
| to bypass Scipp's safety check on broadcasting variances. | ||
|
|
||
| Details will be published in an upcoming publication by Simon Heybrock et al. |
There was a problem hiding this comment.
I would be careful with making such promises about publishing something. This may never happen?
There was a problem hiding this comment.
Then we should not use it.
Anyway, I have a very early draft, but it needs more work.
Co-authored-by: Neil Vaytet <[email protected]>
Does #69 help with fixing the CI I wonder? |
Refactor to handle wavelength bands during normalization step
|
I merged #68, which already fixed the problem, I think this will pass now. |
This uses an upper-bound error estimate. Fixes #61.
Also fixes #64.