fix: dont reread files in sans2d workflow #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/examples/zoom.ipynb
Outdated
Comment on lines
132
to
133
| " sans.common.transmission_from_background_run,\n", | ||
| " sans.common.transmission_from_sample_run,\n", |
There was a problem hiding this comment.
Maybe importing this top-level in __init__.py would make sense? common is meaningless to a user, but sans.transmission_from_sample_run can be understood?
jokasimr
force-pushed
the
fix-dont-reread-files
branch
from
d936a5d
to
a0856d5
Compare
SimonHeybrock
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46