Workflow widget interface #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/loki/workflow_test.py
Outdated
Comment on lines
79
to
102
| # Select tutorial workflow | ||
| select = widget.children[0].children[0] | ||
| keys, values = zip(*select.options, strict=True) | ||
| ind = keys.index('LokiAtLarmorTutorialWorkflow') | ||
| select.value = values[ind] | ||
| # Select IofQ[SampleRun] output | ||
| wfw = widget.children[1].children[0] | ||
| outputs = wfw.output_selection_box.typical_outputs_widget | ||
| keys, values = zip(*outputs.options, strict=True) | ||
| ind = keys.index('IofQ[SampleRun]') | ||
| outputs.value = (values[ind],) | ||
| # Refresh parameters | ||
| pbox = wfw.parameter_box | ||
| pbox.parameter_refresh_button.click() | ||
| # Enable DirectBeam input | ||
| pbox._input_widgets[DirectBeam].children[0].enabled = True | ||
| pbox._input_widgets[DirectBeam].children[0].wrapped._option_box.value = None | ||
| # Run the workflow | ||
| rbox = wfw.result_box | ||
| rbox.run_button.click() | ||
| # Inspect results | ||
| (da,) = results.values() | ||
| assert da.dims == ('Q',) | ||
| assert da.sizes['Q'] == pbox._input_widgets[QBins].children[0].fields['nbins'].value |
There was a problem hiding this comment.
Won't a test like this break all the time as we refactor and improve the widget code? Can we avoid it (for now at least)?
There was a problem hiding this comment.
Sure. Does this mean I should also remove the notebook, as it uses the same code to make the widget come alive?
There was a problem hiding this comment.
Let us leave it for now? I hope once we implement a way to save the widget config that would be solved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs scipp/essreduce#109 for builds to pass.