-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example workflow for Loki to enable beamlime #123
Conversation
What's the policy about adding dependencies like beamlime here? Should I just add it as a proper dependency or as an optional one as it is only required by a specific code path. |
We have not actually discussed this specific case. The live-data dashboard will not be run by regular users, but "by us" on a dedicated machine (VM), so personally I would think we can simply not add beamlime as a dependency (and install by hand when needed). |
Maybe keep this is an optional dependency then? Could be easier to track all deps required for live-data dashboard (if and when more are added) in a single place. Something like |
You are right, this might be what we do in the long run. But as Beamlime (and in particular this plugin mechanism) is in a very early state we might wait a little. |
This setups a workflow to address scipp/beamlime#159.
Not too sure where to keep the function but for now I have created a new file.
Fixes scipp/beamlime#159.