Add "JSON" generator to facilitate testing of live workflows in downstream packages #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
added a commit
to scipp/esssans
that referenced
this pull request
Oct 4, 2024
Requires scipp/essreduce#115 for CI to pass.
jl-wynen
reviewed
Oct 7, 2024
| generator = event_data_generator(monitor) | ||
| for i in range(len(monitor)): | ||
| group = json_nexus_group(next(generator)) | ||
| assert_identical(group[()], monitor[i : i + 1]) |
There was a problem hiding this comment.
Can you add a test that the generator has finished after the loop? I.e., that next(generator) raises StopIteration. Asking because the loop uses monitor and not generator.
| Parameters | ||
| ---------- | ||
| data: | ||
| A data array with event data, equivalent to what ScippNexus would load from an |
There was a problem hiding this comment.
Hmm, do you mean the return value? This docstring line is about the input.
There was a problem hiding this comment.
Yes, I meant the return value. My bad.
Can you add an explanation of it? In particular, there is no explanation of how data is encoded.
jl-wynen
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this only supports NXevent_data. More might be added in the future.