Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize_json #18

Merged
merged 5 commits into from
Jun 29, 2023
Merged

harmonize_json #18

merged 5 commits into from
Jun 29, 2023

Conversation

frheault
Copy link
Member

@frheault frheault commented May 2, 2023

Simplify handling of missing data in the JSON for tractometry analysis.

@frheault frheault changed the title (WIP) harmonize_json harmonize_json May 29, 2023
@frheault
Copy link
Member Author

@arnaudbore I think this is now an important PR as it solves a big problem.

When computing fixel stuff, 1) it was taking distance and label map as metrics and since each bundle has one, it was computing like 100 metrics more per bundle by accident.
2) The json/xlsx were broken since the afd_metric had a unique name per bundle rather than an uniformed name.

This PR fixes this as well as making sure the json/xlsx are well constructed for analysis. (we should have a call about this, its hard to explain)

I think someone should test this with
2-3 subjects, not the exact same bundle and metric for each subject and carefully examine the plot and json/xlsx and we should have a call about it.

I think this has been for some time.

@frheault
Copy link
Member Author

frheault commented Jun 1, 2023

@Manonedde maybe you could test this PR (can be used with scilpy master) and investigate the output in depth to see if everything that has to disappear is gone?

@Manonedde
Copy link

No problem, I'll look at it next week.

@Manonedde
Copy link

@arnaudbore @frheault
I tested on 10 subjects, 2 bundles and 4 metrics (DTI + AFD fixel).
The 2 problems mentioned above for the fixel stuff are solved. The json and excel no longer contain labels and distances; and afd_metric had a uniform name.

@arnaudbore arnaudbore merged commit 9b75bcd into scilus:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants