Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bundle suffix in Fixel_AFD process #14

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Remove bundle suffix in Fixel_AFD process #14

merged 1 commit into from
Aug 19, 2022

Conversation

ppoulin91
Copy link
Contributor

  • Bundle suffix was not removed in Fixel_AFD, leading to AFD output filenames with the suffix, (e.g. "UF_R_m_cleaned_afd_metric.nii.gz"). Consequently, the following processes cannot match bundle names between .trk files and AFD Nifti files. For example, "Bundle_Endpoints_Metrics" computes the cross product of all bundles with all bundle_afd_metrics instead of matching each bundle with its afd metric.

@ppoulin91
Remove bundle suffix in Fixel_AFD process
789ab96 
- Bundle suffix was not removed in Fixel_AFD, leading to AFD output filenames with the suffix, (e.g. "UF_R_m_cleaned_afd_metric.nii.gz"). Consequently, the following processes cannot match bundle names between .trk files and afd Nifti files. For example, "Bundle_Endpoints_Metrics" computes the cross product of all bundles with all bundle_afd_metrics instead of matching each bundle with its afd metric.
@arnaudbore arnaudbore requested a review from frheault June 12, 2022 22:25
@ppoulin91
Copy link
Contributor Author

@mdesco : Please merge for CQDM

mdesco
mdesco approved these changes Aug 18, 2022
View reviewed changes
Copy link

@mdesco mdesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go! @arnaudbore can you merge please?

@arnaudbore arnaudbore merged commit 62677c6 into scilus:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdesco mdesco mdesco approved these changes

@frheault frheault Awaiting requested review from frheault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppoulin91 @mdesco @arnaudbore