-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix verifications in volume_resample #986
Fix verifications in volume_resample #986
Conversation
470e30d
to
987ae9c
Compare
Hello @EmmaRenauld, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-26 19:05:40 UTC |
987ae9c
to
3452087
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #986 +/- ##
==========================================
+ Coverage 68.01% 68.07% +0.06%
==========================================
Files 419 419
Lines 21567 21577 +10
Branches 3241 3245 +4
==========================================
+ Hits 14668 14688 +20
+ Misses 5608 5601 -7
+ Partials 1291 1288 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (just 2 small comments)
Reverted recent change in scil_volume_resample, that input image and ref had to be compatible: not here! Ref is the reference to which to reshape.
res
meant: the final shape of the image. Usually, resolution is the voxel shape! Renamed.