Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dvc requirements #938

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

AlexVCaron
Copy link
Collaborator

Quick description

Update DVC now that iterative/dvc-data#513 is merged

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Provide data, screenshots, command line to test (if relevant)

test_aodf_metrics.py will pass and that says it all

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.49%. Comparing base (73d1aa5) to head (f6e5af5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #938   +/-   ##
=======================================
  Coverage   69.49%   69.49%           
=======================================
  Files         392      392           
  Lines       20966    20966           
  Branches     3207     3207           
=======================================
  Hits        14570    14570           
  Misses       5093     5093           
  Partials     1303     1303           
Components Coverage Δ
Scripts 71.93% <ø> (ø)
Library 65.48% <ø> (ø)

@arnaudbore arnaudbore merged commit a865a55 into scilus:master Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants