Reconst scripts part4

[EmmaRenauld]

Quick description

Checked the final scripts in our reconst column. Didn't find anything to take out of mains: no new function. Only more comments, fixing prints, etc.

...

Type of change

Check the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

• My code follows the style guidelines of this project (run autopep8)
• I added relevant citations to scripts, modules and functions docstrings and descriptions
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I moved all functions from the script file (except the argparser and main) to scilpy modules
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pep8speaks]

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-07 18:22:39 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.52%. Comparing base (4491228) to head (91e5856).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   69.46%   69.52%   +0.06%     
==========================================
  Files         390      392       +2     
  Lines       20944    20970      +26     
  Branches     3205     3207       +2     
==========================================
+ Hits        14548    14579      +31     
+ Misses       5093     5090       -3     
+ Partials     1303     1301       -2     

Components	Coverage Δ
Scripts	71.96% <88.88%> (+0.04%)	⬆️
Library	65.51% <100.00%> (+0.09%)	⬆️

[karanphil]

Few renaming and it's GTG!

[arnaudbore]

GTG