Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split load_and_verify_mti function #933

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

karanphil
Copy link
Contributor

Quick description

New little PR! First, I changed the name of the function io.mti.verifications_and_loading_mti to io.mti.load_and_verify_mti. Then, I simply added two new local functions _parse_acquisition_parameters and _prepare_B1_map, making the big function less big.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 69.50%. Comparing base (4491228) to head (b981950).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   69.46%   69.50%   +0.04%     
==========================================
  Files         390      392       +2     
  Lines       20944    20972      +28     
  Branches     3205     3207       +2     
==========================================
+ Hits        14548    14576      +28     
  Misses       5093     5093              
  Partials     1303     1303              
Components Coverage Δ
Scripts 71.93% <100.00%> (+0.01%) ⬆️
Library 65.51% <70.58%> (+0.09%) ⬆️

@arnaudbore arnaudbore requested review from arnaudbore and EmmaRenauld and removed request for arnaudbore March 6, 2024 15:46
@arnaudbore arnaudbore merged commit 16579b4 into scilus:master Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants