Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding msmt support to set_frf_diffusivities #896

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Feb 13, 2024

Quick description

I added multi-shell support to scil_frf_set_diffusivities.py. It only took a few modifcations, and single-shell works as before. This was added with the goal of running it in nf-scil. I added tests also, and a check on the format of the input new_frf.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Feb 13, 2024

Hello @karanphil, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-02-14 16:49:27 UTC

@karanphil karanphil requested a review from arnaudbore February 13, 2024 15:03
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82b98a1) 65.92% compared to head (dedb657) 65.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   65.92%   65.92%           
=======================================
  Files         384      384           
  Lines       21331    21337    +6     
  Branches     3491     3492    +1     
=======================================
+ Hits        14063    14067    +4     
- Misses       5664     5665    +1     
- Partials     1604     1605    +1     
Components Coverage Δ
Scripts ∅ <ø> (∅)
Library ∅ <ø> (∅)

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pep8 and GTG

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore merged commit 1e9f814 into scilus:master Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants