Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: gradients.bvec_bval_tools #885

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

EmmaRenauld
Copy link
Contributor

Quick description

Unit tests for methods in bvec_val_tools.

(Moved fsl2mrtrix and mrtrix2fsl out of there, to io.gradients, because they load and save data. To avoid having to load data in unit tests).

...

Type of change

Check the relevant options.

  • Unit tests :)

Provide data, screenshots, command line to test (if relevant)

pytest scilpy/gradients/tests/test_bvec_bval_tools.py

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@pep8speaks
Copy link

pep8speaks commented Jan 24, 2024

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-02-14 15:14:17 UTC

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41078d0) 65.91% compared to head (f0bc75a) 65.95%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   65.91%   65.95%   +0.04%     
==========================================
  Files         384      384              
  Lines       21341    21337       -4     
  Branches     3494     3493       -1     
==========================================
+ Hits        14067    14073       +6     
+ Misses       5668     5659       -9     
+ Partials     1606     1605       -1     
Components Coverage Δ
Scripts ∅ <ø> (∅)
Library ∅ <ø> (∅)

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore merged commit 6872d0d into scilus:master Feb 14, 2024
1 check passed
@EmmaRenauld EmmaRenauld deleted the test_gradients branch February 14, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants