Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gdrive endpoint for tests #877

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

AlexVCaron
Copy link
Collaborator

@AlexVCaron AlexVCaron commented Jan 16, 2024

Quick description

Tests are not passing because of a confirmation on large file download from gdrive. This fies the endpoint used so the confimation works.
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

Run the tests or wait for Jenkins

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore self-requested a review January 16, 2024 04:03
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@AntoineTheb
Copy link
Contributor

AntoineTheb commented Jan 16, 2024

Could it be a good time to move away from Google Drive for test data ? Something like git-lfs ? They could be in a separate repo, which would be pulled when running tests. We could even pull specific branches which include new test data whenever we need to add more !

@AlexVCaron
Copy link
Collaborator Author

Yes., this is a temporary fix. We are testing DVC right now, it looks like it'll do the trick.

@arnaudbore arnaudbore merged commit 767a116 into scilus:master Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants