Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to dipy 1.8 #853

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Update to dipy 1.8 #853

merged 8 commits into from
Jan 12, 2024

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@arnaudbore arnaudbore requested a review from frheault December 14, 2023 16:52
@arnaudbore
Copy link
Contributor Author

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-853/1/

@frheault
Copy link
Member

Switch nibabel==4.* to 5.*

@arnaudbore
Copy link
Contributor Author

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-853/2/

@arnaudbore
Copy link
Contributor Author

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-853/3/

@frheault
Copy link
Member

File scilpy/image/tests/test_labels.py, test test_get_data_as_labels_int:
Line 107 img = nib.Nifti1Image(data, np.eye(4)) should become img = nib.Nifti1Image(data, np.eye(4), dtype=np.int64)

This will have to become a part of our routine when saving as int64, which is rare. We mostly save as uint8 (mask) uint16 (labels) or float32/float64 for everything else.

(I also updated with master, everything seems to work)

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor Author

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-853/5/

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@EmmaRenauld
Copy link
Contributor

Do we need to change something in the README? I don't think we need to install stuff before anymore, like
pip install packaging>=19.0
pip install numpy==1.23.*
pip install Cython==0.29.*

(I didn't and it worked, locally)

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit f8ea9ee into scilus:master Jan 12, 2024
0 of 5 checks passed
@arnaudbore arnaudbore deleted the use_dipy_1.8 branch January 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frheault frheault Awaiting requested review from frheault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaudbore @frheault @EmmaRenauld