Adding tolerance argument to fodf msmt #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @karanphil, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-08 15:09:45 UTC |
|
Build Failed 💥 |
|
Build Failed 💥 |
|
Build passed ! Good Job 🍻 ! |
|
Build passed ! Good Job 🍻 ! |
mdesco
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #830 from @mdesco , I added a tolerance argument to
scil_fodf_msmt.py. It was simply hardcoded to tol=20 in one function, and set to default (20) in another. This was in fact a potential breaking point even if it ran. I just had to give the option.@mdesco could you try to run it again on your setup? Thanks!