Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General testing for all legacy scripts #838

Merged
merged 7 commits into from
Dec 8, 2023
Merged

General testing for all legacy scripts #838

merged 7 commits into from
Dec 8, 2023

Conversation

gabknight
Copy link
Contributor

@gabknight gabknight commented Dec 7, 2023 •
edited
Loading

Added a test that calls all scilpy 1.6.0 scripts (170 scripts!). This replaces all others scilpy/legacy/tests/test*.py files.

@pep8speaks
Copy link

pep8speaks commented Dec 7, 2023 •
edited
Loading

Hello @gabknight, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-08 14:38:09 UTC

@arnaudbore arnaudbore self-requested a review December 7, 2023 17:59
@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-838/1/

@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-838/2/

@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-838/3/

@gabknight gabknight changed the title WIP - General testing for all legacy scripts General testing for all legacy scripts Dec 7, 2023
@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-838/4/

@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-838/5/

@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-838/6/

@gabknight
Copy link
Contributor Author

Script scil_fix_dsi_studio_trk.py is missing. Was this renamed and is this missing a legacy script or was it a dev script that got removed?

@gabknight
Copy link
Contributor Author

gabknight commented Dec 8, 2023 •
edited
Loading

It was renamed before we have the legacy folder - d831edb

I'll add the legacy script. I'll also renamed it scil_tractogram_fix_trk.py

EmmaRenauld
EmmaRenauld approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

EmmaRenauld
EmmaRenauld reviewed Dec 8, 2023
View reviewed changes
scripts/tests/test_tractogram_fix_trk.py
@@ -3,5 +3,5 @@


def test_help_option(script_runner):
ret = script_runner.run('scil_convert_tractogram.py', '--help')
ret = script_runner.run('scil_tractogram_fix_trk.py', '--help')
assert ret.success
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In version 1.6., there was no more testing than the help?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's complicated to find example of bad trk :( I will open an issue

@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-838/7/

@arnaudbore arnaudbore merged commit beb7365 into scilus:master Dec 8, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmmaRenauld EmmaRenauld EmmaRenauld approved these changes

@arnaudbore arnaudbore Awaiting requested review from arnaudbore

Assignees
No one assigned
Labels
restructuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabknight @pep8speaks @arnaudbore @EmmaRenauld