Moving OP out of the default output files from scil_btensor_metrics.py. #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @karanphil, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-06 21:25:26 UTC |
|
Build Failed 💥 |
|
Build passed ! Good Job 🍻 ! |
|
Build Failed 💥 |
|
Build passed ! Good Job 🍻 ! |
mdesco
reviewed
Dec 7, 2023
| mean diffusivity (MD), isotropic mean kurtosis (mk_i), anisotropic mean | ||
| kurtosis (mk_a), total mean kurtosis (mk_t) and finally micro-FA (uFA). | ||
| Specific names can be specified using the | ||
| file flags specified in the "File flags" section. |
There was a problem hiding this comment.
Maybe add a sentence about OP + FA here even you repeat yourself slightly...
There was a problem hiding this comment.
I don't want people to think it has a link with the File flags and --not_all. That is why I talk about it after at line 23. Is it ok?
mdesco
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #831 from @mdesco, I removed the order parameter (OP) from the default output metrics. You now need to explicitly tell the OP output file path with
--op, if not, it will not be computed. You get a parser error if the FA is not also given (with --fa), since it is needed to compute the OP.