Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reorder_dwi #835

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@arnaudbore arnaudbore requested a review from karanphil December 6, 2023 19:45
@pep8speaks
Copy link

pep8speaks commented Dec 6, 2023

Hello @arnaudbore, Thank you for updating !

Line 79:80: E501 line too long (82 > 79 characters)

Comment last updated at 2023-12-07 13:59:08 UTC

@arnaudbore arnaudbore requested a review from frheault December 6, 2023 20:24
@arnaudbore
Copy link
Contributor Author

@arnaudbore
Copy link
Contributor Author

scripts/scil_dwi_reorder_philips.py Outdated Show resolved Hide resolved
scripts/scil_dwi_reorder_philips.py Outdated Show resolved Hide resolved
scripts/scil_dwi_reorder_philips.py Outdated Show resolved Hide resolved
scripts/scil_dwi_reorder_philips.py Outdated Show resolved Hide resolved
scripts/scil_dwi_reorder_philips.py Show resolved Hide resolved
@karanphil
Copy link
Contributor

Also, I would specify in the doc at the top that this script is not needed for version R5.6 and higher.

Copy link
Contributor

@karanphil karanphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

' ').split()[0]
if version.parse(SOFTWARE_VERSION_MIN) <= version.parse(curr_version):
sys.exit('ERROR: There is no need for reording since your '
'dwi comes from a philips machine with '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

philips -> Philips

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 259d3e9 into scilus:master Dec 7, 2023
@arnaudbore arnaudbore deleted the update_philips_reorder branch January 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants