-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename reorder_dwi #835
Rename reorder_dwi #835
Conversation
Hello @arnaudbore, Thank you for updating !
Comment last updated at 2023-12-07 13:59:08 UTC |
Build Failed 💥 |
Build Failed 💥 |
Also, I would specify in the doc at the top that this script is not needed for version R5.6 and higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
scripts/scil_dwi_reorder_philips.py
Outdated
' ').split()[0] | ||
if version.parse(SOFTWARE_VERSION_MIN) <= version.parse(curr_version): | ||
sys.exit('ERROR: There is no need for reording since your ' | ||
'dwi comes from a philips machine with ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
philips -> Philips
Build passed ! Good Job 🍻 ! |
No description provided.