Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy test (help) #833

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Conversation

EmmaRenauld
Copy link
Contributor

I copied all tests such as they were 2 months ago.

I tested all legacy scripts (that are in master as of today dec 5th). Then, I removed all tests except the help. So now it does not verify that the legacy scripts import the right main. But at least it verifies for typos.

In next PRs, we should recommand first copy-pasting the test in legacy.

@arnaudbore arnaudbore self-requested a review December 5, 2023 16:50
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove import fetcher in legacy tests

@pep8speaks
Copy link

pep8speaks commented Dec 6, 2023

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-06 15:50:00 UTC

@arnaudbore arnaudbore self-requested a review December 6, 2023 16:33
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore merged commit 9baf955 into scilus:master Dec 6, 2023
5 checks passed
@EmmaRenauld EmmaRenauld deleted the add_legacy_test_help branch December 6, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants