-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename convert scripts #828
Conversation
Build passed ! Good Job 🍻 ! |
Build passed ! Good Job 🍻 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to say except that I don't think scil_convert_rgb.py
should go in the reconst module. Maybe scil_io_convert?
For Nitpicking, I like it more with the verb at the end: |
I think we need to finish PK's PR for reconst first ( #822 ) because if we move the metrics to something else than reconst, then it will be something like scil_metrics_convert_rgb. If we keep them in reconst, then reconst is fine here too. |
Build Failed 💥 |
Build Failed 💥 |
Build Failed 💥 |
Build Failed 💥 |
Hello @arnaudbore, Thank you for updating ! |
Build passed ! Good Job 🍻 ! |
scil_convert_tractogram.py -> scil_tractogram_convert.py
scil_convert_gradients_mrtrix_to_fsl.py -> scil_gradients_convert_mrtrix_to_fsl.py
scil_convert_gradients_fsl_to_mrtrix.py -> scil_gradients_convert_fsl_to_mrtrix.py
scil_convert_rgb.py -> scil_rgb_convert.py