Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename surface scripts #827

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Dec 4, 2023

scil_smooth_surface.py - > scil_surface_smooth.py
scil_flip_surface.py -> scil_surface_flip.py
scil_apply_transform_to_surface.py -> scil_surface_apply_transform.py
scil_convert_surface.py -> scil_surface_convert.py

@pep8speaks
Copy link

pep8speaks commented Dec 4, 2023

Hello @arnaudbore, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-05 19:27:07 UTC

@arnaudbore arnaudbore changed the title Rename surface scripts [WIP] Rename surface scripts Dec 4, 2023
@arnaudbore arnaudbore changed the title [WIP] Rename surface scripts Rename surface scripts Dec 4, 2023
@arnaudbore arnaudbore requested a review from frheault December 4, 2023 21:11
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

Copy link
Contributor

@karanphil karanphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted one error in scil_convert_surface.py legacy. Also, if the module is named surfaceS, shouldn't we call the scripts scil_surfaces ? I would prefer to just rename the module to surface.

As for the changes in the scripts, I don't really know these scripts to judge them.

Good job!

scripts/legacy/scil_convert_surface.py Outdated Show resolved Hide resolved
@EmmaRenauld
Copy link
Contributor

if the module is named surfaceS, shouldn't we call the scripts scil_surfaces ? I would prefer to just rename the module to surface.

We did the same with module tractograms --> scil_tractogram_... So I think it's ok.

I did it with labels too but in this case I named the scripts scil_labels_ because you always have many labels.

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

scripts/scil_surface_apply_transform.py Outdated Show resolved Hide resolved
scripts/scil_surface_apply_transform.py Show resolved Hide resolved
scripts/scil_surface_flip.py Show resolved Hide resolved
scilpy/surfaces/surface_operations.py Outdated Show resolved Hide resolved
@arnaudbore
Copy link
Contributor Author

@arnaudbore
Copy link
Contributor Author

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit b05af38 into scilus:master Dec 6, 2023
5 checks passed
@arnaudbore arnaudbore deleted the rename_surface_scripts branch January 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants