-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename surface scripts #827
Conversation
Hello @arnaudbore, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-05 19:27:07 UTC |
Build passed ! Good Job 🍻 ! |
1 similar comment
Build passed ! Good Job 🍻 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted one error in scil_convert_surface.py legacy. Also, if the module is named surfaceS, shouldn't we call the scripts scil_surfaces ? I would prefer to just rename the module to surface.
As for the changes in the scripts, I don't really know these scripts to judge them.
Good job!
We did the same with module tractograms --> scil_tractogram_... So I think it's ok. I did it with labels too but in this case I named the scripts scil_labels_ because you always have many labels. |
Build passed ! Good Job 🍻 ! |
Build Failed 💥 |
Build Failed 💥 |
Build passed ! Good Job 🍻 ! |
scil_smooth_surface.py - > scil_surface_smooth.py
scil_flip_surface.py -> scil_surface_flip.py
scil_apply_transform_to_surface.py -> scil_surface_apply_transform.py
scil_convert_surface.py -> scil_surface_convert.py