Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dwi scripts #823

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Conversation

karanphil
Copy link
Contributor

Hi! I changed the name of all "dwi" scripts to follow the new idea of scil_module_function. Here are the changes:

  • scil_apply_bias_field_on_dwi.py -> scil_dwi_apply_bias_field.py
  • scil_extract_b0.py -> scil_dwi_extract_b0.py
  • scil_extract_dwi_shell.py -> scil_dwi_extract_shell.py
  • scil_split_dwi.py -> scil_dwi_split_by_indices.py
  • scil_concatenate_dwi.py -> scil_dwi_concatenate.py
  • scil_compute_powder_average.py -> scil_dwi_powder_average.py

Don't hesitate to give your opinion on the changes! I think this is more straight forward than the reconst scripts.

@mdesco @arnaudbore @EmmaRenauld

@pep8speaks
Copy link

pep8speaks commented Dec 1, 2023

Hello @karanphil, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-12-01 12:54:08 UTC

@arnaudbore arnaudbore self-requested a review December 1, 2023 13:35
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudbore arnaudbore merged commit 8cdf844 into scilus:master Dec 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants