-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning reconst module #806
Conversation
Build Failed 💥 |
Hello @karanphil, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-11-21 16:28:37 UTC |
Build passed ! Good Job 🍻 ! |
1 similar comment
Build passed ! Good Job 🍻 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Tested all scripts except the b-tensor encoding stuff... Did not have b-tensor data at hand...
Build Failed 💥 |
Build Failed 💥 |
Build passed ! Good Job 🍻 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
I applied the following modifications to the module scilpy.reconst (and other modules impacted):
scilpy.reconst:
divide_fit.py renamed divide.py
multi_processes.py:
fit_from_model moved to fodf.py
peaks_from_sh, maps_from_sh, convert_sh_basis, convert_sh_to_sf moved to sh.py
fit_gamma moved to divide.py
multi_processes.py has been removed
afd_along_streamlines.py and lobe_metrics_along_streamlines.py moved to scilpy.tractanalysis
raw_signals.py:
compute_dwi_attenuation moved to scilpy.dwi.operations.py
raw_signals.py renamed dwi.py
b_tensor_utils.py moved to scilpy.io.b_tensor.py
docs.source.modules was updated for reconst.
scilpy.dwi: