Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning reconst module #806

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Nov 13, 2023

I applied the following modifications to the module scilpy.reconst (and other modules impacted):

scilpy.reconst:

  • divide_fit.py renamed divide.py

  • multi_processes.py:
    fit_from_model moved to fodf.py
    peaks_from_sh, maps_from_sh, convert_sh_basis, convert_sh_to_sf moved to sh.py
    fit_gamma moved to divide.py
    multi_processes.py has been removed

  • afd_along_streamlines.py and lobe_metrics_along_streamlines.py moved to scilpy.tractanalysis

  • raw_signals.py:
    compute_dwi_attenuation moved to scilpy.dwi.operations.py
    raw_signals.py renamed dwi.py

  • b_tensor_utils.py moved to scilpy.io.b_tensor.py

  • docs.source.modules was updated for reconst.

scilpy.dwi:

  • new: operations.py
  • rescale_dwi (and _rescale_intensity) moved from utils.py to operations.py

@arnaudbore arnaudbore self-requested a review November 13, 2023 16:55
@arnaudbore
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Nov 13, 2023

Hello @karanphil, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-21 16:28:37 UTC

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@mdesco mdesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Tested all scripts except the b-tensor encoding stuff... Did not have b-tensor data at hand...

@arnaudbore
Copy link
Contributor

@arnaudbore
Copy link
Contributor

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore merged commit cacbb9b into scilus:master Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants