Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update memsmt fodf script [requires dipy 1.8.0] #791

Merged
merged 8 commits into from
Jan 19, 2024
Merged

Update memsmt fodf script [requires dipy 1.8.0] #791

merged 8 commits into from
Jan 19, 2024

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Oct 24, 2023 •
edited
Loading

Quick description

WIP.

Updating and cleaning the scil_compute_memsmt_fodf.py script according to the last Dipy release. Will be testable when this release comes.

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Oct 24, 2023 •
edited
Loading

Hello @karanphil, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-19 16:28:51 UTC

@arnaudbore arnaudbore self-requested a review October 24, 2023 20:43
@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-791/1/

@arnaudbore arnaudbore changed the title [WIP] Update memsmt fodf script [WIP] Update memsmt fodf script [requires dpy 1.8.0] Oct 27, 2023
@arnaudbore arnaudbore changed the title [WIP] Update memsmt fodf script [requires dpy 1.8.0] [WIP] Update memsmt fodf script [requires dipy 1.8.0] Oct 27, 2023
@arnaudbore
Copy link
Contributor

Build Failed 💥
https://jenkins.scil.usherbrooke.ca/job/scilpy/job/PR-791/2/

@arnaudbore arnaudbore added the WIP Work In Progress label Nov 2, 2023
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@karanphil
Copy link
Contributor Author

@mdesco could you quickly test this PR with the data from McGill? After that I think it is good to go.

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

arnaudbore
arnaudbore approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @mdesco tests, otherwise LGTM

@arnaudbore arnaudbore changed the title [WIP] Update memsmt fodf script [requires dipy 1.8.0] Update memsmt fodf script [requires dipy 1.8.0] Jan 15, 2024
mdesco
mdesco reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mdesco mdesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--in_bdeltas argument is not clear to me. What is the correct format for the argparser. Can you provide a clear help or example please.

@karanphil
Copy link
Contributor Author

--in_bdeltas argument is not clear to me. What is the correct format for the argparser. Can you provide a clear help or example please.

I added an example of command line in each script.

@arnaudbore arnaudbore self-requested a review January 17, 2024 17:35
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

mdesco
mdesco approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@mdesco mdesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karanphil. All good on my end.

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

arnaudbore
arnaudbore approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudbore arnaudbore merged commit faa0e0c into scilus:master Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbore arnaudbore arnaudbore approved these changes

@mdesco mdesco mdesco approved these changes

Assignees
No one assigned
Labels
WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karanphil @pep8speaks @arnaudbore @mdesco