Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DWI module #781

Merged
merged 6 commits into from
Oct 23, 2023
Merged

DWI module #781

merged 6 commits into from
Oct 23, 2023

Conversation

mdesco
Copy link
Contributor

@mdesco mdesco commented Oct 23, 2023

  • created dwi module
  • dwi/utils.py
  • moved a function out of scil_apply_dwi... into the utils.py

@mdesco
Copy link
Contributor Author

mdesco commented Oct 23, 2023

@EmmaRenauld @arnaudbore pour votre review.

arnaudbore
arnaudbore reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there !

scilpy/dwi/utils.py Show resolved Hide resolved
scilpy/dwi/utils.py Show resolved Hide resolved
@arnaudbore arnaudbore self-requested a review October 23, 2023 19:47
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 9be36ad into scilus:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbore arnaudbore Awaiting requested review from arnaudbore

Assignees
No one assigned
Labels
restructuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdesco @arnaudbore @EmmaRenauld