Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test volume_math #778

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

frheault
Copy link
Member

These tests assume their underlying implementation in Scipy/Numpy do not change.

There would be just too much explicit definition of an expected array to do it all by hand.

@pep8speaks
Copy link

pep8speaks commented Oct 23, 2023

Hello @frheault, Thank you for updating !

Line 215:80: E501 line too long (97 > 79 characters)

Comment last updated at 2023-11-02 18:32:37 UTC

@arnaudbore arnaudbore self-requested a review October 23, 2023 18:34
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small modification but otherwise LGTM

scilpy/image/tests/test_volume_math.py Outdated Show resolved Hide resolved
scilpy/io/fetcher.py Outdated Show resolved Hide resolved
@arnaudbore arnaudbore self-requested a review November 2, 2023 19:19
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudbore arnaudbore merged commit 579582a into scilus:master Nov 3, 2023
@frheault frheault deleted the test_volume_math_2 branch February 28, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants