Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asym clean up #776

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Asym clean up #776

merged 7 commits into from
Oct 23, 2023

Conversation

mdesco
Copy link
Contributor

@mdesco mdesco commented Oct 23, 2023

  • 2 functions out of the script
  • new module aodf.py in reconst

Test passed.

@mdesco mdesco requested review from CHrlS98 and karanphil October 23, 2023 17:28
@pep8speaks
Copy link

pep8speaks commented Oct 23, 2023

Hello @mdesco, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-10-23 18:59:38 UTC



#
# aodf := Assymetric Orientation Distribution Function (aODF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asymmetric*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think you could remove some empty lines above

scilpy/reconst/aodf.py Show resolved Hide resolved
scilpy/reconst/aodf.py Show resolved Hide resolved
@arnaudbore arnaudbore self-requested a review October 23, 2023 18:04
@arnaudbore
Copy link
Contributor

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@CHrlS98 CHrlS98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this style thing and then it will be ready to merge

scilpy/reconst/aodf.py Outdated Show resolved Hide resolved
scilpy/reconst/aodf.py Outdated Show resolved Hide resolved
scilpy/reconst/aodf.py Outdated Show resolved Hide resolved
scilpy/reconst/aodf.py Outdated Show resolved Hide resolved
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit e3fdd0a into scilus:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants