Working Scilpy development container for VS Code #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arnaudbore @frheault This does not really need review, but I think this will interest you both. Could be really nice for onboarding and creating dev setups for projects/internships/homeworks |
|
Build passed ! Good Job 🍻 ! |
2 similar comments
|
Build passed ! Good Job 🍻 ! |
|
Build passed ! Good Job 🍻 ! |
|
Can you write some instructions about this in scilpy readthedoc ? |
|
Build passed ! Good Job 🍻 ! |
1 similar comment
|
Build passed ! Good Job 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adding to the repository the necessary files to enable the creation of a development container in VS Code. Once merged, users will be able to automatically create a development environment through VS Code, that contains the whole Scilus development stack (ANTs, FSL, Mrtrix, etc.), and develop Scilpy in it.
In addition to VS Code, this requires Docker, to create the development container - spawning the containers takes a few minutes (depending on the user's internet speed). The containers comes pre-equiped with Git and several VS Code extensions to streamline development, and is connected to docker outside the container (so it can build images as well).
Once created, VS Code opens an IDE inside the container, where Scilpy is installed. The user can then develop Scilpy, interact with repositories through Git, run tests inside the container and modify its content (the user has read/write permissions), and much more.
As of now, the only binding between the local machine and the container is through the Scilpy repository directory. We could consider adding other bindings, but this needs a bit of research.
Marche-à-suivre to test the container creation :