ENH: Verbose tracking #714
Conversation
EmmaRenauld
force-pushed
the
verbose_tracking
branch
from
d7e3c04 to
d04c2ff
Compare
|
Build passed ! Good Job 🍻 ! |
1 similar comment
|
Build passed ! Good Job 🍻 ! |
|
Yay ! I actually do it locally anyway, so I'm all for it. |
| if scaled_min_length <= length(s) <= scaled_max_length)) | ||
| if args.verbose: | ||
| filtered_streamlines, seeds = \ | ||
| zip(*((s, p) for s, p in tqdm( |
There was a problem hiding this comment.
Tu pourrais wrapper tqdm pour sauver un if-else imbriqué. Au dessus de if args.save_seeds, tu pourrais déclarer un truc du genre (pas testé)
def tqdm_wrapper(generator, *args, **kwargs):
if args.verbose:
return tqdm(generator, args, kwargs)
return generator
Pis après utiliser tqdm_wrapper(streamlines_generator) partout
There was a problem hiding this comment.
Cool, bonne idée. Je vais checker ça.
J'ai essayé dans le dev. Mais le tqdm dans la boucle for fonctionne pas avec le multi-processing. J'ai checké un peu et j'ai trouvé des solutions dans le cas de générateurs, mais pas dans des boucles qu'on update manuellement. Si tu trouves comment, hésite pas! |
|
Thanks Antoine for the contribution. Now this works for the dev tracking too, even with multiprocessing.
|
|
Build Failed 💥 |
|
Build Failed 💥 |
|
Tests pass locally. @arnaudbore or @frheault can you help me find the bug? |
|
Build Failed 💥 |
EmmaRenauld
force-pushed
the
verbose_tracking
branch
from
b8088b7 to
b895ddd
Compare
|
Build passed ! Good Job 🍻 ! |
Just for a better user experience. Previously, option -v in scil_compute_local_tracking did not output any verbose at all. No way to know if the code has even started.
Using TQDM, with a refresh rate of 1% of the total number of seeds (only with option -v).
Also sneeking in a verification of the format with save_seed option.
Example of output:
