Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display masks as contours in screenshots #705

Merged
merged 19 commits into from
Aug 15, 2023

Conversation

AlexVCaron
Copy link
Collaborator

Add capabilities to display mask overlays as contour instead of transparency. Integration into mosaic overlay script and new script to create multiple screenshots from one volume. Multiple examples are provided in the scripts documentation for tests.

@arnaudbore arnaudbore self-requested a review April 6, 2023 15:27
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@AntoineTheb
Copy link
Contributor

Nice ! Do you have data to test this ?

@AlexVCaron
Copy link
Collaborator Author

AlexVCaron commented Apr 25, 2023

Here you go ! You can try it with pretty much any data with masks you have though.

@AlexVCaron AlexVCaron force-pushed the feat/display_mask_contour branch from 0030ecf to 78082eb Compare May 17, 2023 19:42
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Is there a way to make these 2 scripts more lookalike (more similar args) ? Can you add an option to add if wanted the number of each slice and L-R position ?

@AlexVCaron AlexVCaron force-pushed the feat/display_mask_contour branch from 1510794 to 122e060 Compare July 26, 2023 19:52
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@AlexVCaron
Copy link
Collaborator Author

Here is a small script to test all the parameters variations of both screenshotting scripts. You have to supply a few files, defined in the script at the top.

@arnaudbore arnaudbore merged commit 858345f into scilus:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants