Fix multiprocess in dev tracking #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build passed ! Good Job 🍻 ! |
|
What was the impact of this bug? Everything would crash? Cause I'm pretty sure I ran the dev tracking with multiprocessing successfully at some point... |
|
Yes, everything crashed. And I don't understand, me too, I think it worked at some point. But yesterday, I ran it with this modified code and it worked. |
EmmaRenauld
force-pushed
the
fix_multiprocess
branch
from
c7aefd3 to
50f4e90
Compare
|
Build passed ! Good Job 🍻 ! |
EmmaRenauld
force-pushed
the
fix_multiprocess
branch
from
01c886d to
7fe5fba
Compare
CHrlS98
approved these changes
Mar 1, 2023
|
Build passed ! Good Job 🍻 ! |
2 similar comments
|
Build passed ! Good Job 🍻 ! |
|
Build passed ! Good Job 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During multiprocessing Pool, the argument sent is a dict, but the multiprocessing sends it as *args, thus deconstructing the dict.
Modifying to (dict, ), so that instead it will diconstruct the tuple and leave the dict intact.
Not sure how we did not find this bug sooner... Sorry.