Fixing uniform_coloring in scil_visualize_bunldes.py #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build passed ! Good Job 🍻 ! |
AntoineTheb
approved these changes
Jan 31, 2023
|
@karanphil Can you update this code with master and then check if everything runs normally. |
|
Build passed ! Good Job 🍻 ! |
|
Works fine with python 3.10! |
frheault
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick fix of the
uniform_coloringoption inscil_visualize_bunldes.py. The color was given in RGB (in range [0, 255]) but the viewer used range [0, 1], so I kept the 0 to 255 as input and divided by 255 before feeding it to the viewer. @AntoineTheb