Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding variance to scil_visualize_fodf #671

Merged
merged 8 commits into from
Mar 7, 2023

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Jan 30, 2023

This is simply an attempt to merge an old branch of @CHrlS98 into the main script scil_visualize_fodf.py. With my simulations, I have a lot of repetitions of the same fODF reconstruction so I compute the variance of it. This addition allows us to view the variance as another fODF behind the "real" one, with the color of your choice. Note that you need to input the mean + some factor of the variance to get the right visual effect.

Here is some data to test it. Also, it would be useful if users of this script try a typical command to confirm that I didn't break anything. @CHrlS98 @jhlegarreta

https://usherbrooke-my.sharepoint.com/:f:/g/personal/karp2601_usherbrooke_ca/EuPAjEN6VHlNi4-MGW3rjwcBCLNpkCRNuMD1F_K3PRxH8w?e=wY35T7

With this data, try: scil_visualize_fodf.py wm_fodf_mean.nii.gz --variance wm_fodf_var.nii.gz --axis_name coronal --sph_subdivide 2 --bg_color 1 1 1 --color_rgb 0 0.65 0.35 --var_color 0.6 0.6 0.6, this will show the fODFs with a grey outline representing the fODF + 2 * std.

@arnaudbore arnaudbore self-requested a review January 30, 2023 21:09
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @karanphil.

I seem not to have access to the shared data, so I could not test it. I'd be willing to give it a try if you put the data available again.

Otherwise, I tested the mosaic overlap script with structural data only and the changes introduced in here do not seem to have undesired side-effects.

scilpy/viz/scene_utils.py Outdated Show resolved Hide resolved
@karanphil
Copy link
Contributor Author

Thanks for doing this @karanphil.

I seem not to have access to the shared data, so I could not test it. I'd be willing to give it a try if you put the data available again.

Otherwise, I tested the mosaic overlap script with structural data only and the changes introduced in here do not seem to have undesired side-effects.

It should work now!

Copy link
Contributor

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work now!

Have just tested. The provided data and command work well for the purpose. Nice Philippe.

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@karanphil
Copy link
Contributor Author

Works fine with python 3.10!

Copy link
Member

@frheault frheault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comment: Good to go

scripts/scil_visualize_fodf.py Outdated Show resolved Hide resolved
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@karanphil karanphil closed this Mar 7, 2023
@karanphil karanphil reopened this Mar 7, 2023
@arnaudbore arnaudbore self-requested a review March 7, 2023 16:40
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 749f9f6 into scilus:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants