-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module tractogram operations #658
Module tractogram operations #658
Conversation
On our toDo list for this PR: |
4566000
to
8688810
Compare
Build Failed 💥 |
Build passed ! Good Job 🍻 ! |
Build passed ! Good Job 🍻 ! |
I tested a few scripts and it still works (I think, I need to do it again with better data). Do you think its possible to leave the old script that would print a warning (deprecated script) and then just call the new one (or may just point the user to the new one). I am afraid changing scil_streamlines_math.py to scil_tractogram_math.py will generate a ton of email like 'WHERE IS THAT SCRIPT' for the next year. PS: Yes, just delete the scil_remove_similar_streamlines.py, and delete functions that are unique to that script (or not reusable) It is an over- engineered script that no one use. I will keep a copy in a personal graveyard. |
84488ab
to
f727cb6
Compare
Build Failed 💥 |
Build passed ! Good Job 🍻 ! |
Build passed ! Good Job 🍻 ! |
Build passed ! Good Job 🍻 ! |
I think it would be important to leave a warning in scil_streamlines_math.py until the next release, but make it so it still works for a few months as a transition. The easiest way would be that scil_tractogram_math.py has a main() with the argparser build, but then the whole content of the main is moved to another function that accepts args and parser as arguments. Then scil_streamlines_math could display the warning, but then call the sub-function from the other script with its own parser and args. This way, without duplication of code, the user can still use it and get a warning without all the flows and scripts crashing. This will be removed a few months later, so a complete deprecation cycle). |
Build passed ! Good Job 🍻 ! |
Continuing the refactoring work, as discussed in group.
Explanation:
Based on our analysis of the scripts, we will create a new section scilpy.tractograms, which should contain:
This PR:
Creation of tractogram_operations.py and lazy_tractogram_operations.
Fonctions that were copy-pasted with no change:
New methods created to clean mains in scripts:
Other change:
@frheault , @AntoineTheb , @AlexVCaron