BF for asymmetric peaks

[CHrlS98]

Quick description

Closes #1072 . The argument opacity was missing. Also made keywords mandatory for optional arguments. I don't have data to test every use case, but what I could test does work.

Type of change

Check the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

Checklist

• My code follows the style guidelines of this project (run autopep8)
• I added relevant citations to scripts, modules and functions docstrings and descriptions
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I moved all functions from the script file (except the argparser and main) to scilpy modules
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pep8speaks]

Hello @CHrlS98, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-16 18:28:02 UTC

[karanphil]

Looks good to me! I learned this *, trick today.

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (660d7c9) to head (cb5fd80).
Report is 50 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   69.46%   69.45%   -0.01%     
==========================================
  Files         447      447              
  Lines       24052    24053       +1     
  Branches     3291     3291              
==========================================
- Hits        16708    16707       -1     
- Misses       5946     5947       +1     
- Partials     1398     1399       +1     

Components	Coverage Δ
Scripts	70.25% <100.00%> (-0.02%)	⬇️
Library	68.39% <83.33%> (ø)

[arnaudbore]

GTG